fix: show full hyperlinks in Konsole (#10964)

Fixes #10964

fix: show full hyperlinks in Konsole (#10964)
ee4910e3 · Marc Cornellà · f80cf120 · ee4910e3 · ee4910e3
Unverified Commit ee4910e3 authored Oct 12, 2022 by Marc Cornellà
Hide whitespace changes
Inline Side-by-side

Showing with 16 additions and 4 deletions

install.sh tools/install.sh +8 -2

upgrade.sh tools/upgrade.sh +8 -2

No files found.
--- a/tools/install.sh
+++ b/tools/install.sh
@@ -156,11 +156,17 @@ supports_hyperlinks() {
    return 0
  fi

-  # Windows Terminal or Konsole also support hyperlinks
-  if [ -n "$WT_SESSION" ] || [ -n "$KONSOLE_VERSION" ]; then
+  # Windows Terminal also supports hyperlinks
+  if [ -n "$WT_SESSION" ]; then
    return 0
  fi

+  # Konsole supports hyperlinks, but it's an opt-in setting that can't be detected
+  # https://github.com/ohmyzsh/ohmyzsh/issues/10964
+  # if [ -n "$KONSOLE_VERSION" ]; then
+  #   return 0
+  # fi
+
  return 1
 }


--- a/tools/upgrade.sh
+++ b/tools/upgrade.sh
@@ -78,11 +78,17 @@ supports_hyperlinks() {
    return 0
  fi

-  # Windows Terminal or Konsole also support hyperlinks
-  if [ -n "$WT_SESSION" ] || [ -n "$KONSOLE_VERSION" ]; then
+  # Windows Terminal also supports hyperlinks
+  if [ -n "$WT_SESSION" ]; then
    return 0
  fi

+  # Konsole supports hyperlinks, but it's an opt-in setting that can't be detected
+  # https://github.com/ohmyzsh/ohmyzsh/issues/10964
+  # if [ -n "$KONSOLE_VERSION" ]; then
+  #   return 0
+  # fi
+
  return 1
 }